SDSS-1314: Drupal 10.3 / PHP 8.3 #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
October 24, 2024 15:35
added 12 commits
October 25, 2024 16:52
mdyoung3
reviewed
Nov 5, 2024
| @@ -73,7 +73,9 @@ public function save(array $form, FormStateInterface $form_state) { | |||
| elseif ($status == SAVED_NEW) { | |||
| $message = $this->t('The SDSS entity type %name has been added.', $t_args); | |||
| } | |||
| $this->messenger()->addStatus($message); | |||
| if ($message) { | |||
There was a problem hiding this comment.
@joegl You might want to initialize this variable ($message).
pookmish
reviewed
Nov 5, 2024
| + | ||
| +################################################################################### | ||
| +# | ||
| +# * |
There was a problem hiding this comment.
Wat? a big drupal drop in a patch. 🤷
There was a problem hiding this comment.
Yea the merge request also adds in the gitlab-ci.yml 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review Tasks
Setup tasks and/or behavior to test
Front End Validation
Backend / Functional Validation
Code
Code security
General
Affected Projects or Products
Associated Issues and/or People
SDSS-1314: DEV | Upgrade to Drupal 10.3.x and PHP 8.3
Resources