Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-933: Ability to feature content at the top of lists #479

Open
wants to merge 3 commits into
base: 4.x
Choose a base branch
from

Conversation

buttonwillowsix
Copy link
Contributor

NOT READY FOR REVIEW

Summary

SDSS users would like the ability to force an item to the top of a list. For this functionality, we decided to use Drupal's built-in Sticky at top of lists. This PR reveals the existing field on the form and adds displays that use it.

Review By (Date)

  • End of FY24, if possible, or early FY25

Criticality

Medium

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Make a people, news, events, or basic page list on a Basic Page
  3. Set some content to be sticky at top of lists
  4. Use views (TBA which ones) to verify that it works.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@github-actions github-actions bot added size/m and removed size/s labels Aug 15, 2024
@github-actions github-actions bot added size/s and removed size/m labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant