Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-1337: Track news sharing imported content #478

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

joegl
Copy link
Collaborator

@joegl joegl commented Aug 14, 2024

READY FOR REVIEW

Summary

  • Track News articles imported via News Sharing through new boolean field
  • Don't include imported articles in News Sharing feeds
  • Database updates to create the boolean field and enable it on all existing imported content

Review By (Date)

8/20

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to...
  3. Verify...

Associated Issues and/or People

https://stanfordits.atlassian.net/browse/SDSS-1337

@github-actions github-actions bot added size/s and removed size/xs labels Aug 14, 2024
@joegl
Copy link
Collaborator Author

joegl commented Aug 19, 2024

@pookmish I assigned for review for just the database update code. I'm pulling already migrated nodes and setting a field value. It works but I'm not sure if it's the best way.

Copy link
Contributor

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you have works fine. It's equally as efficient, so it's up to you if you'd like to use my comments.

docroot/profiles/sdss/sdss_profile/sdss_profile.install Outdated Show resolved Hide resolved
docroot/profiles/sdss/sdss_profile/sdss_profile.install Outdated Show resolved Hide resolved
@joegl joegl merged commit c2303a1 into 4.x Aug 22, 2024
5 checks passed
@joegl joegl deleted the SDSS-1337--track-news-sharing-imported-content branch August 22, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants