Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-1299: Explore More Improvements #461

Closed
wants to merge 10 commits into from

Conversation

buttonwillowsix
Copy link
Contributor

@buttonwillowsix buttonwillowsix commented Jul 3, 2024

NOT READY FOR REVIEW

Summary

  • Create curated and random views for Explore More
  • Created new field to allow author to choose which view to display, with random view as default

Review By (Date)

  • In time to release pre-Aug 31

Criticality

-HIGH

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Create a bunch of news
  3. Verify that different news items show up in the Explore More section (not the same ones on every page)
  4. Then curate content on a news item. Verify that the random news is replaced with the curated news.

Front End Validation

No new front-end code

Backend / Functional Validation

Code

  • [ YES] Are the naming conventions following our standards?
  • [ NOPE] Does the code have sufficient inline comments?
  • [ NOPE] Is there anything in this code that would be hidden or hard to discover through the UI?
  • [NOPE ] Are there any code smells?
  • [ NEED TESTS] Are tests provided? eg (unit, behat, or codeception)

General

  • [NOPE ] Is there anything included in this PR that is not related to the problem it is trying to solve?
  • [SHRUG ] Is the approach to the problem appropriate?

Affected Projects or Products

  • SDSS News
  • News throughout the SDSS stack

Associated Issues and/or People

  • SDSS-1299

Resources

@buttonwillowsix buttonwillowsix self-assigned this Jul 3, 2024
@github-actions github-actions bot added the size/m label Jul 3, 2024
@github-actions github-actions bot added size/l and removed size/m labels Jul 5, 2024
@github-actions github-actions bot added size/m and removed size/l labels Jul 5, 2024
@github-actions github-actions bot added size/l and removed size/m labels Jul 6, 2024
@buttonwillowsix
Copy link
Contributor Author

Closing this in favor of #466 (faster than reverting)

@buttonwillowsix buttonwillowsix deleted the SDSS-1299-explore-more-fixes branch July 22, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant