Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-973: Change dash to underscore in blt.yml for abc_hub. #244

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

joegl
Copy link
Collaborator

@joegl joegl commented Sep 27, 2023

READY FOR REVIEW

Summary

  • TL;DR - what's this PR for?

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? See Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to...
  3. Verify...

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@@ -22,7 +22,7 @@ cm:
strategy: config-split
allow-overrides: true
multisites:
- abc-hub
- abc_hub
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdyoung3 I just want to flag this change for you. The alias in this file should be the one with the underscore "_" and not the dash "-".

This most likely won't be a problem in any future provisions, because this line is auto-added with the multisite:init script, and I know we made you change from abchub to abc-hub after the original provision. I am guessing you probably changed this line manually or with find and replace and I didn't catch it in the PR review.

@joegl joegl merged commit 493dd2a into 2.x Sep 27, 2023
3 of 4 checks passed
@joegl joegl deleted the SDSS-973--fix-gitpod-abchub branch September 27, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant