Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-968: Implement Media Contacts QA feedback #241

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Sep 26, 2023

READY FOR REVIEW

Summary

  • For all Breakpoints: add a 10px margin-bottom to the School/Dept
  • For SM-XXL (when names are in two columns) - Increase grid space in between two rows of names, from 40px to 60px
  • For MD-XXL:
    -- Add margin-top to all of the names on the right: MS(0)
    --Change font-style of phone number and email address to card-paragraph (font-size: 2rem)

Review By (Date)

  • Next release

Criticality

  • How critical is this PR on a 1-10 scale? See Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to a news page
  3. Add a set of Media Contacts
  4. Verify the spacing.

Screenshot 2023-09-27 at 10 46 48 AM
Screenshot 2023-09-27 at 10 44 49 AM
Screenshot 2023-09-27 at 10 39 12 AM

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-968

Resources

@joegl joegl changed the title SDSS-968: media contacts QA feedback SDSS-968: Implement Media Contacts QA feedback Sep 28, 2023
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joegl joegl merged commit f9f3429 into 2.x Sep 28, 2023
4 checks passed
@joegl joegl deleted the SDSS-968--media-contact-qa branch September 28, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants