Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-888: Swapping abchub with abc-hub #239

Merged
merged 4 commits into from
Sep 27, 2023
Merged

SDSS-888: Swapping abchub with abc-hub #239

merged 4 commits into from
Sep 27, 2023

Conversation

mdyoung3
Copy link
Contributor

READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • Adding abc-hub

Ticket: https://stanfordits.atlassian.net/browse/SDSS-888

@mdyoung3 mdyoung3 changed the title SDSS - 888 adding abc hub SDSS - 888 swapping abchub with abc-hub Sep 25, 2023
@mdyoung3 mdyoung3 changed the title SDSS - 888 swapping abchub with abc-hub SDSS-888 - swapping abchub with abc-hub Sep 25, 2023
@joegl
Copy link
Collaborator

joegl commented Sep 26, 2023

@mdyoung3 Sites with dashes - in the alias should be using an underscore _ in place of the dash - when provisioning. The directory name, drush aliases, etc., should all be underscores _ (e.g., abc_hub).

There's a number of existing sites to choose from as a reference: https://github.com/SU-SWS/ace-sdssgryphon/tree/2.x/docroot/sites

Here is a PR with a bunch to reference as well: #136

@mdyoung3
Copy link
Contributor Author

@joegl Right. I forgot to fix that. Sorry.

@mdyoung3 mdyoung3 requested a review from joegl September 26, 2023 22:38
@mdyoung3
Copy link
Contributor Author

@joegl Should be good.

@joegl joegl changed the title SDSS-888 - swapping abchub with abc-hub SDSS-888: Swapping abchub with abc-hub Sep 27, 2023
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again for quick turnaround on this.

@joegl joegl merged commit 2466773 into 2.x Sep 27, 2023
4 checks passed
@joegl joegl deleted the SDSS-888-adding-abc-hub branch September 27, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants