Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-937: NEWS | Added top margin to related news section #235

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • Added a margin top to the related news at the foot of a news article.

Review By (Date)

  • 9/19

Criticality

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to a news node
  3. Verify there is additional space above the related news MS(6)
  4. Previous from -test
image
  1. Now
Screenshot 2023-09-16 at 10 22 51 AM

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-937

Resources

@joegl joegl changed the title SDSS-937: margin top to the related news SDSS-937: NEWS | Added top margin to related news section Sep 22, 2023
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jen!

@joegl joegl merged commit bee9507 into 2.x Sep 22, 2023
3 of 4 checks passed
@joegl joegl deleted the SDSS-937--margins branch September 22, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants