Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-477: A11Y | Fixed button text color on Event pages #233

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • The event button color did not pass a11y tests

Review By (Date)

  • 9/21

Criticality

  • normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to events. sample event: /events/classseminar/sfi-seminar-summer-fellowship-program-student-spotlights-0
  3. Log in to the site.
  4. Then Edit the Event and then choose View.
  5. The events all link out to the events sites so this is the way to get to the page.
  6. Verify the CTA button looks like a primary button style.
  7. What it should look like

Screenshot 2023-09-13 at 3 54 02 PM
9. What prod looks like
10.
Screenshot 2023-09-13 at 3 55 31 PM

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-477

Resources

@joegl joegl changed the title SDSS-477: fixed the button text color for event pages SDSS-477: Fixed the button text color on Event pages Sep 14, 2023
@joegl joegl changed the title SDSS-477: Fixed the button text color on Event pages SDSS-477: A11Y | Fixed button text color on Event pages Sep 14, 2023
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Jen

@joegl joegl merged commit f061137 into 2.x Sep 14, 2023
4 checks passed
@joegl joegl deleted the SDSS-477--button-color branch September 14, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants