SDSS-451, SDSS-452: Adjust margin and padding for color variant paragraph rows

[jenbreese]

READY FOR REVIEW

Summary

• Reducing the margin-bottom on content rows to MS(1) from MS(4)
• This change is only for content that has a white background. The different green and blue rows have overrides to this margin bottom.
• Reducing the padding-top on content colored row variants to MS(1) from MS(4)

Review By (Date)

• 9/21

Criticality

• Normal

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Navigate to the homepage
3. Verify the white content rows have a margin-bottom of ~26px or MS(1)
4. Production

6. Local change
7.

8. Note, I put in borders to facilitate seeing the space change. Those will not appear when building the code.
9. Verify the color content row variants have a padding-top of ~26px or MS(1)
10. Production
11.

12. Local change
13.

Front End Validation

• Is the markup using the appropriate semantic tags and passes HTML validation?
• Cross-browser testing has been performed?
• Automated accessibility scans performed?
• Manual accessibility tests performed?
• Design is approved by @ user?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-451
-SDSS-452

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[joegl]

LGTM, thanks Jen!