Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-175: Reduce font-size on default list filter by menu #231

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Sep 13, 2023

READY FOR REVIEW

Summary

  • Changed the filter by menu to 19px from ~23px

Review By (Date)

  • 9/21

Criticality

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to a default list page such as these: /news/honors-awards , /events/classseminar , /publications, /people
  3. Verify the items in the list menu are now 1.9rem instead.
  4. Production.
    SDSS-175--production
  5. Fixed locally

SDSS-175--local with fix

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-175

Resources

@jenbreese jenbreese assigned jenbreese and joegl and unassigned jenbreese Sep 13, 2023
@joegl joegl changed the title SDSS-175: changed font on filter-by menu to smaller size SDSS-175: Reduce font-size on default list filter by menu Sep 14, 2023
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for the screenshots Jen!

@joegl joegl merged commit 3bacc1e into 2.x Sep 14, 2023
4 checks passed
@joegl joegl deleted the SDSS-175--filter-by-menu branch September 14, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants