Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-900: Fix callout quote symbols for Windows #230

Merged
merged 2 commits into from
Sep 13, 2023
Merged

SDSS-900: Fix callout quote symbols for Windows #230

merged 2 commits into from
Sep 13, 2023

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Sep 13, 2023

READY FOR REVIEW

Summary

  • The quotes were only working properly on the mac

Review By (Date)

  • ASAP, this is to fix a problem that is currently on Staging

Criticality

  • Medium

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to a news page and add a callout quote
  3. Verify the curly quotes appear and not the straight ones.
  4. This is what is currently on the test site:

image
6. This is what we'd like it to look like. It is a curly quote in the serif font.
Screenshot 2023-09-13 at 1 53 21 PM

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- Original change ticket - SDSS-900

  • This was a bug found and is a hot fix.

Resources

@jenbreese jenbreese changed the title SDSS-900: qoutes were only working on the mac SDSS-900: curly quotes were only working on the mac Sep 13, 2023
@joegl joegl changed the title SDSS-900: curly quotes were only working on the mac SDSS-900: Fix callout quote symbols for Windows Sep 13, 2023
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is what I see!
test-callout

@joegl joegl merged commit d4f8729 into 2.x Sep 13, 2023
4 checks passed
@joegl joegl deleted the SDSS-900--fixup branch September 13, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants