Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDSS-888: Provisioned abchub #229

Merged
merged 5 commits into from
Sep 13, 2023
Merged

SDSS-888: Provisioned abchub #229

merged 5 commits into from
Sep 13, 2023

Conversation

mdyoung3
Copy link
Contributor

@mdyoung3 mdyoung3 commented Sep 13, 2023 •
edited
Loading

READY FOR REVIEW

Summary

  • Provision abchub for Lesly

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? See Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

No testing needed. (Will test after deployment per Joe's provisioning document.)

Associated Issues and/or People

@mdyoung3 mdyoung3 requested a review from joegl September 13, 2023 17:30
@joegl
Copy link
Collaborator

joegl commented Sep 13, 2023

@mdyoung3 PR title should be: "SDSS-888: Provisioned abchub"

@joegl joegl changed the title SDSS-888 - abchub multisite scaffolding SDSS-888: Provisioned abchub Sep 13, 2023
joegl
joegl approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @mdyoung3 !

Since these are very straightforward feel free to only include the alias of the site you're provisioning and a link to the ticket in the PR notes (and a due date if it's urgent).

@joegl joegl merged commit 88953c6 into 2.x Sep 13, 2023
@joegl joegl deleted the SDSS-888-provision-abchub branch September 13, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegl joegl joegl approved these changes

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdyoung3 @joegl