Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-520: Updated Localist migration to import images #227

Merged
merged 2 commits into from
Sep 12, 2023
Merged

SDSS-520: Updated Localist migration to import images #227

merged 2 commits into from
Sep 12, 2023

Conversation

imonroe
Copy link
Contributor

@imonroe imonroe commented Sep 8, 2023

READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

  • In SDSS-525, a "Featured Image" field was created for the Event type. This modifies the migration for the Localist importer to include the featured image if it is available in Localist.

Review By (Date)

  • 🤷‍♂️

Criticality

  • 3

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. drush @sustainability.local cim
  3. Run the Localist importer. Check to see if the imported events have an image. Not every event will necessarily have an image. Check it against Localist to ensure it has imported the correct image.
  4. You can also verify that the images have been imported in the Media Library.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@github-actions github-actions bot added the size/s label Sep 8, 2023
@github-actions github-actions bot added size/xs and removed size/s labels Sep 11, 2023
@imonroe imonroe requested a review from joegl September 11, 2023 17:51
@joegl joegl changed the title SDSS-520: updated localist migration to import images SDSS-520: Updated Localist migration to import images Sep 12, 2023
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Ian

@joegl joegl merged commit fb0303d into 2.x Sep 12, 2023
4 checks passed
@joegl joegl deleted the SDSS-520 branch September 12, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants