SDSS-885: NEWS | Style Media Contacts display

[jenbreese]

READY FOR REVIEW

Summary

• Theming for the Media Contacts

Review By (Date)

• 9/1

Criticality

• Normal

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Create a news page
3. Add Media Captions
4. Verify they look like the designs.
5. Note: I had some comments about the markup in the backend 595 PR and I fixed the mark up ones in this one.

Front End Validation

• Is the markup using the appropriate semantic tags and passes HTML validation?
• Cross-browser testing has been performed?
• Automated accessibility scans performed?
• Manual accessibility tests performed?
• Design is approved by @ user?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-885
- SDSS-594 - the backend work

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[joegl]

Verify they look like the designs.

@jenbreese In the future can you link directly to designs I should be comparing to in PR's? Thanks! Screenshots in the PR itself would be easiest -- FIGMA takes time to load and it's easy for me to get lost in there.

[joegl]

LGTM. Thanks Jen!