Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-821: Adjusted dek line height on News nodes #213

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • Changed the line hight of the Newsroom article Long Dek to 1.3

Review By (Date)

  • Soon

Criticality

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to an article page
  3. Verify the long dek has a line height of 1.3

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-821

Resources

@jenbreese jenbreese requested a review from joegl August 15, 2023 20:24
@jenbreese jenbreese self-assigned this Aug 15, 2023
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joegl joegl changed the title SDSS-821: changing the line height of the dek only SDSS-821: Adjusted dek line height on News nodes Aug 22, 2023
@joegl joegl merged commit 91ee2b3 into 2.x Aug 22, 2023
4 checks passed
@joegl joegl deleted the SDSS-821--dek branch August 22, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants