Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-862: Adjusted component reference field settings. #210

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

joegl
Copy link
Collaborator

@joegl joegl commented Aug 15, 2023

READY FOR REVIEW

Summary

PR addresses two things:

  • Initially fixes a "bug" where new paragraph types we added (editorial sidebar, layout, callout quote) were enabled in all component reference fields when they were created. These should only be available for the News content type component field.
  • Secondarily this changes all paragraph reference behavior from "exclude selected" to "include selected". This effectively makes all new paragraph types an "opt-in" instead of "opt-out" so we have to explicitly enable a paragraph type in a paragraph reference field for it to be used.

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? See Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to...
  3. Verify...

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@joegl joegl merged commit 96b95cc into 2.x Aug 17, 2023
4 checks passed
@joegl joegl deleted the SDSS-862--hide-layout-paragraph branch August 17, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant