Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-827: Adjust Callout Quote component alignment #209

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Aug 14, 2023

READY FOR REVIEW

Summary

  • Changing the padding and max-width of a callout quote.
  • The changes will be noticed in responsive views in particular.

Review By (Date)

  • 8/24

Criticality

  • normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to a page with a callout quote or add your own.
  3. Verify there is a max-width of 1200px on the quote.
  4. Verify it is centered.
  5. Verify the padding is on the outer container.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-827

Resources

Base automatically changed from SDSS-844--html-errors to 2.x August 15, 2023 18:44
@joegl joegl changed the title SDSS-827: callout alignment SDSS-827: Adjust Callout Quote component alignment Aug 30, 2023
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jen!

@joegl joegl merged commit 857eec2 into 2.x Aug 30, 2023
4 checks passed
@joegl joegl deleted the SDSS-827--callout-alignment branch August 30, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants