Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-844: A11y | Accessibility improvements for Callout Quote #208

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • HTML errors in the Callout Quote paragraph

Review By (Date)

  • 8/20

Criticality

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to a page and create a callout quote
  3. Verify it passed html validation. There are details in the ticket with the steps to use a local html validator.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-844

Resources

@jenbreese jenbreese requested a review from joegl August 14, 2023 17:57
@joegl joegl changed the title SDSS-844: fix to html errors SDSS-844: A11y | Accessibility improvements for Callout Quote Aug 15, 2023
Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by the ticket, only 1 of the 2 errors is fixed and the other is in core? I'm going to approve knowing this addresses 1 A11y issue.

@joegl joegl merged commit 02a3493 into 2.x Aug 15, 2023
4 checks passed
@joegl joegl deleted the SDSS-844--html-errors branch August 15, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants