Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-812: SQUIZ | Add and enable Stanford Syndication module #207

Merged
merged 8 commits into from
Feb 20, 2024
Merged

Conversation

pookmish
Copy link
Contributor

@pookmish pookmish commented Aug 11, 2023

READY FOR REVIEW ?

Summary

  • add stanford syndication module

@pookmish
Copy link
Contributor Author

@joegl this can be deployed to dev environments. Then the access token just needs to be added on the configure form and it should begin to work.

Copy link
Collaborator

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pookmish Did you want me to pull this down and test out anything? Outside of the commented out line, everything LGTM.

@@ -9,6 +9,7 @@

if (!EnvironmentDetector::isProdEnv()) {
$config['domain_301_redirect.settings']['enabled'] = FALSE;
// $config['stanford_syndication.settings']['enabled'] = FALSE;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment going to be removed and/or changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that is just so we can test it out on dev environments.

@pookmish
Copy link
Contributor Author

pookmish commented Oct 2, 2023

This is just to put it on your plate. I don't know the timeline when they hope to get it on the production sites. So update that settings.php and merge whenever they are expecting it.

@joegl
Copy link
Collaborator

joegl commented Nov 29, 2023

@pookmish We're going to deploy this branch to the dev environment tomorrow for testing. What would I need to do to get it ready and set up once I deploy (or is there anything I need to do)? Thanks

@pookmish
Copy link
Contributor Author

yeah you do have to add the API token on /admin/config/services/syndication path. You'll have to look through the emails or documentation they provided for that token. The token is stored in state (stanford_enterprise.token) so the token has to be entered manually or via drush on each site.

@joegl joegl changed the base branch from 2.x to 4.x December 1, 2023 17:01
@joegl
Copy link
Collaborator

joegl commented Feb 20, 2024

@pookmish Sounds like they are ready for this in production. Anything need to be changed in here or can I merge it (after fixing conflicts obviously)?

@pookmish
Copy link
Contributor Author

@joegl You'll want to uncomment the line in the settings.php to prevent syndication from non-prod environments. And update the composer.json file to the beta release for the syndication module.

@joegl joegl changed the title Disable syndication on non-prod environments SDSS-812: Add and enable Stanford Syndication module Feb 20, 2024
@joegl joegl changed the title SDSS-812: Add and enable Stanford Syndication module SDSS-812: SQUIZ | Add and enable Stanford Syndication module Feb 20, 2024
@joegl joegl merged commit 5d94fee into 4.x Feb 20, 2024
3 of 4 checks passed
@joegl joegl deleted the SDSS-812 branch February 20, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants