-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDSS-812: SQUIZ | Add and enable Stanford Syndication module #207
Conversation
@joegl this can be deployed to dev environments. Then the access token just needs to be added on the configure form and it should begin to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pookmish Did you want me to pull this down and test out anything? Outside of the commented out line, everything LGTM.
@@ -9,6 +9,7 @@ | |||
|
|||
if (!EnvironmentDetector::isProdEnv()) { | |||
$config['domain_301_redirect.settings']['enabled'] = FALSE; | |||
// $config['stanford_syndication.settings']['enabled'] = FALSE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment going to be removed and/or changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that is just so we can test it out on dev environments.
This is just to put it on your plate. I don't know the timeline when they hope to get it on the production sites. So update that settings.php and merge whenever they are expecting it. |
@pookmish We're going to deploy this branch to the dev environment tomorrow for testing. What would I need to do to get it ready and set up once I deploy (or is there anything I need to do)? Thanks |
yeah you do have to add the API token on |
@pookmish Sounds like they are ready for this in production. Anything need to be changed in here or can I merge it (after fixing conflicts obviously)? |
@joegl You'll want to uncomment the line in the settings.php to prevent syndication from non-prod environments. And update the composer.json file to the beta release for the syndication module. |
READY FOR REVIEW ?
Summary