SDSS-840: Add unsectioned News paragraphs to layout_paragraph sections

[joegl]

READY FOR REVIEW

Summary

• We changed the components field from Classic Paragraphs to Layout Paragraphs, but none of the paragraphs were added to sections.
• This adds an updatedb hook that moves any "un-sectioned" components into a 1 column layout section.
• This is affecting the site visually (the one column section keeps the paragraphs "centered") -- this is visible

Review By (Date)

• ASAP

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Sync the Sustainability site blt drupal:sync --site=sustainability
3. Run the updatedb hooks (if they haven't run already) drush updatedb
4. Ensure all News components are in a section now.

Front End Validation

• Is the markup using the appropriate semantic tags and passes HTML validation?
• Cross-browser testing has been performed?
• Automated accessibility scans performed?
• Manual accessibility tests performed?
• Design is approved by @ user?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

https://stanfordits.atlassian.net/browse/SDSS-840

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[joegl]

@pookmish I know I was pushing fixups after I re-requested review -- this is ready now.

[pookmish]

This still doesn't address one possible scenario:

one column
  - text area
text area 2
two column
  - card
  - text area 3
card 2

In this instance text area 2 and card 2 would end up belonging to the same one column layout and result in the order of the items changing. It would result in this outcome:

one column
  - text area
two column
  - card
  - text area 3
one column
  - text area 2
  - card 2

The chance of this happening is probably slim to none but it is a possibility. The only way to truely solve such a scenario is to create one column rows for ever "unsectioned" paragraph.

[joegl]

This still doesn't address one possible scenario:

one column
  - text area
text area 2
two column
  - card
  - text area 3
card 2

In this instance text area 2 and card 2 would end up belonging to the same one column layout and result in the order of the items changing. It would result in this outcome:

one column
  - text area
two column
  - card
  - text area 3
one column
  - text area 2
  - card 2

The chance of this happening is probably slim to none but it is a possibility. The only way to truely solve such a scenario is to create one column rows for ever "unsectioned" paragraph.

I re-wrote the code to add every "unsectioned" paragraph to its own section paragraph, and then spliced the section paragraph into the component list at the same delta as the original paragraph + however many new paragraphs have been added for that node.

[pookmish]

Thanks for addressing my concerns.

[joegl]

Thanks for addressing my concerns.

Thanks for all your feedback. It was really constructive and I learned a lot.