Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug on DLL resolve for plugins #380

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

antoineatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

If a loaded plugin requires DLL that is not part of the referenced CDP4 COMET Server, those DLL are not loaded and the system is unable to resolve them, which leads to runtime exception and additional Authentication plugin may not work.

This code resolve this issue, tracks all DLL that has been discovered and loaded during the LoadPlugins process and help resolving missing DLL

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
20.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants