Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Error saving value to ParameterSubscription on ParameterOverride; fixes #355 #356

Conversation

lxatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

[FIX] Error saving value to ParameterSubscription on ParameterOverride; fixes #355

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Contributor

@antoineatstariongroup antoineatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but is PackageReference with pre-release valid?

@lxatstariongroup
Copy link
Contributor Author

lxatstariongroup commented May 24, 2024 via email

@lxatstariongroup lxatstariongroup merged commit 4c2bb84 into development May 24, 2024
5 of 6 checks passed
@lxatstariongroup lxatstariongroup deleted the fix/gh355-ParameterSubscription-on-ParameterOverride-fails branch May 24, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants