Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Next.js Bugs - Fix useLocation + Custom Hook #67

Merged
merged 7 commits into from
Feb 13, 2024
Merged

🐛 Next.js Bugs - Fix useLocation + Custom Hook #67

merged 7 commits into from
Feb 13, 2024

Conversation

Harry-Ross
Copy link
Contributor

@Harry-Ross Harry-Ross commented Feb 13, 2024 •
edited
Loading

Fixes #66

  • Removed react-use dependency, replaced with the searchUrl prop
  • Fixed useMenuItems to render Tina data as its being edited
  • Made external module discovery automatic from package.json instead of external modules being manually added in vite.config.ts - reduction in bundle size in index.js from 92.4 kb to 31.07 kb

@Harry-Ross Harry-Ross marked this pull request as ready for review February 13, 2024 05:57
JackDevAU
JackDevAU approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@JackDevAU JackDevAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Harry-Ross Harry-Ross merged commit 68905cd into main Feb 13, 2024
1 check passed
@Harry-Ross Harry-Ross deleted the fix-uselocation branch February 13, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackDevAU JackDevAU JackDevAU approved these changes

@BrookJeynes BrookJeynes Awaiting requested review from BrookJeynes

@amankumarrr amankumarrr Awaiting requested review from amankumarrr

@wicksipedia wicksipedia Awaiting requested review from wicksipedia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug - Next.js Issues
2 participants
@Harry-Ross @JackDevAU