Skip to content

Commit

Permalink
Applied lint fixes, added PR lint step + Rules usage (#49)
Browse files Browse the repository at this point in the history
* Applied lint fixes, added PR lint step

* Fixed pnpm CI

* fixed to use correct install command

* Fixed name of file, runs on main now

* Removed yarn

* renamed logo to correct filename

* Added rules functionality

* removed arbitrary value

* Removed localstorage caching mechanism

* Added subtitle + title fields instead of logo override

* Added nvmrc

* Added types rollup
  • Loading branch information
Harry-Ross authored Dec 29, 2023
1 parent 6df60eb commit 5850dfc
Show file tree
Hide file tree
Showing 12 changed files with 122 additions and 147,566 deletions.
1 change: 0 additions & 1 deletion .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ module.exports = {
],
"tailwindcss/no-custom-classname": "error",
"tailwindcss/classnames-order": "error",
"tailwindcss/no-arbitrary-value": "warn",
"react/prop-types": "error",
"react/react-in-jsx-scope": "off",
},
Expand Down
24 changes: 24 additions & 0 deletions .github/workflows/lint-code.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Lint code

on:
pull_request:
branches:
- main
push:
branches:
- main

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v2
with:
version: 8.13.0
- uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"
cache: "pnpm"
- run: pnpm i
- run: pnpm lint
7 changes: 2 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Publish Npm Package
name: Publish npm Package

on:
release:
Expand All @@ -7,17 +7,14 @@ on:
jobs:
publish-gpr:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20]
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v2
with:
version: 8.13.0
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version-file: ".nvmrc"
registry-url: "https://registry.npmjs.org"
cache: "pnpm"
- name: Install dependencies 📦️
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lts/*
Loading

0 comments on commit 5850dfc

Please sign in to comment.