Skip to content

πŸ‘€ 117 code review feedback matt goldman #81

πŸ‘€ 117 code review feedback matt goldman

πŸ‘€ 117 code review feedback matt goldman #81

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / Tests succeeded Nov 17, 2023 in 0s

Tests βœ…

Tests passed successfully

Report Passed Failed Skipped Time
Tests/Application.UnitTests/TestResults/TestResults.trx 10βœ… 3s
Tests/Domain.UnitTests/TestResults/TestResults.trx 2βœ… 2s
Tests/Infrastructure.IntegrationTests/TestResults/TestResults.trx 1βœ… 56s
Tests/WebUI.IntegrationTests/TestResults/TestResults.trx 20βœ… 53s

βœ…Β Tests/Application.UnitTests/TestResults/TestResults.trx

10 tests were completed in 3s with 10 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Northwind.Application.UnitTests.Customers.Commands.CreateCustomer.CreateCustomerCommandTests 1βœ… 2s
Northwind.Application.UnitTests.Customers.Queries.GetCustomerDetailQueryHandlerTests 1βœ… 191ms
Northwind.Application.UnitTests.Customers.Queries.GetCustomersListQueryHandlerTests 1βœ… 22ms
Northwind.Application.UnitTests.MappingTests 7βœ… 388ms

βœ…Β Northwind.Application.UnitTests.Customers.Commands.CreateCustomer.CreateCustomerCommandTests

βœ… Handle_GivenValidRequest_ShouldRaiseCustomerCreatedNotification

βœ…Β Northwind.Application.UnitTests.Customers.Queries.GetCustomerDetailQueryHandlerTests

βœ… GetCustomerDetail

βœ…Β Northwind.Application.UnitTests.Customers.Queries.GetCustomersListQueryHandlerTests

βœ… GetCustomersTest

βœ…Β Northwind.Application.UnitTests.MappingTests

βœ… ShouldHaveValidConfiguration
βœ… ShouldMapCategoryToCategoryLookupDto
βœ… ShouldMapCustomerToCustomerDetailVm
βœ… ShouldMapCustomerToCustomerLookupDto
βœ… ShouldMapProductToProductDetailVm
βœ… ShouldMapProductToProductDto
βœ… ShouldMapProductToProductRecordDto

βœ…Β Tests/Domain.UnitTests/TestResults/TestResults.trx

2 tests were completed in 2s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Northwind.Domain.UnitTests.Common.ValueObjectTests 2βœ… 14ms

βœ…Β Northwind.Domain.UnitTests.Common.ValueObjectTests

βœ… Equals_GivenDifferentValues_ShouldReturnFalse
βœ… Equals_GivenMatchingValues_ShouldReturnTrue

βœ…Β Tests/Infrastructure.IntegrationTests/TestResults/TestResults.trx

1 tests were completed in 56s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Northwind.Infrastructure.IntegrationTests.NorthwindDbContextInitializerTests 1βœ… 4s

βœ…Β Northwind.Infrastructure.IntegrationTests.NorthwindDbContextInitializerTests

βœ… SeedAsync_AfterInitializeAsync_PopulatesDatabase

βœ…Β Tests/WebUI.IntegrationTests/TestResults/TestResults.trx

20 tests were completed in 53s with 20 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Northwind.WebUI.IntegrationTests.Controllers.Categories.GetCategoryList 1βœ… 14ms
Northwind.WebUI.IntegrationTests.Controllers.Customers.Create 1βœ… 16ms
Northwind.WebUI.IntegrationTests.Controllers.Customers.Delete 2βœ… 51ms
Northwind.WebUI.IntegrationTests.Controllers.Customers.GetAll 1βœ… 19ms
Northwind.WebUI.IntegrationTests.Controllers.Customers.GetById 2βœ… 37ms
Northwind.WebUI.IntegrationTests.Controllers.Customers.Update 2βœ… 26ms
Northwind.WebUI.IntegrationTests.Controllers.Products.Create 4βœ… 497ms
Northwind.WebUI.IntegrationTests.Controllers.Products.Delete 2βœ… 84ms
Northwind.WebUI.IntegrationTests.Controllers.Products.GetAll 1βœ… 143ms
Northwind.WebUI.IntegrationTests.Controllers.Products.GetById 2βœ… 33ms
Northwind.WebUI.IntegrationTests.Controllers.Products.Update 2βœ… 28ms

βœ…Β Northwind.WebUI.IntegrationTests.Controllers.Categories.GetCategoryList

βœ… ReturnsSuccessResult

βœ…Β Northwind.WebUI.IntegrationTests.Controllers.Customers.Create

βœ… GivenCreateCustomerCommand_ReturnsSuccessStatusCode

βœ…Β Northwind.WebUI.IntegrationTests.Controllers.Customers.Delete

βœ… GivenId_ReturnsSuccessStatusCode
βœ… GivenInvalidId_ReturnsNotFoundStatusCode

βœ…Β Northwind.WebUI.IntegrationTests.Controllers.Customers.GetAll

βœ… ReturnsCustomersListViewModel

βœ…Β Northwind.WebUI.IntegrationTests.Controllers.Customers.GetById

βœ… GivenId_ReturnsCustomerViewModel
βœ… GivenInvalidId_ReturnsNotFoundStatusCode

βœ…Β Northwind.WebUI.IntegrationTests.Controllers.Customers.Update

βœ… GivenUpdateCustomerCommand_ReturnsSuccessStatusCode
βœ… GivenUpdateCustomerCommandWithInvalidId_ReturnsNotFoundStatusCode

βœ…Β Northwind.WebUI.IntegrationTests.Controllers.Products.Create

βœ… CreateProductCommand_WithNoCategory_CreatesProduct
βœ… CreateProductCommand_WithNoSupplier_CreatesProduct
βœ… CreateProductCommand_WithNoUnitPrice_CreatesProduct
βœ… GivenCreateProductCommand_ReturnsNewProductId

βœ…Β Northwind.WebUI.IntegrationTests.Controllers.Products.Delete

βœ… GivenId_ReturnsSuccessStatusCode
βœ… GivenInvalidId_ReturnsNotFoundStatusCode

βœ…Β Northwind.WebUI.IntegrationTests.Controllers.Products.GetAll

βœ… ReturnsProductsListViewModel

βœ…Β Northwind.WebUI.IntegrationTests.Controllers.Products.GetById

βœ… GivenId_ReturnsProductViewModel
βœ… GivenInvalidId_ReturnsNotFoundStatusCode

βœ…Β Northwind.WebUI.IntegrationTests.Controllers.Products.Update

βœ… GivenUpdateProductCommand_ReturnsSuccessStatusCode
βœ… GivenUpdateProductCommandWithInvalidId_ReturnsNotFoundStatusCode