-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hosts: add passkey feature detection in client and IPA #41
Conversation
Does this work? I think this should be run on the IPA server. You want to detect "user-add-passkey" on IPA server and passkey_child or something on the client. |
For client, we can use "builtwith" marker. For IPA server, we can either use the pytest-mh require or extend "builtwith" to also get an optional role parameter which would default to client. |
In PRCI our limiting factor is FreeIPA, as only the latest versions of Fedora include the passkey changes. This was the easiest approach to check that both client and server contain the necessary changes. I checked in the container client that the bash script works, but I've never run the python script that includes it. Is it necessary to create the server infrastructure when the client one is already done? |
|
f4447c8
to
b622e2a
Compare
b622e2a
to
ca35d9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I merged the marker PR. Please rebase.
0b93f56
to
e86c077
Compare
This PR is ready for review again. |
e86c077
to
b6d21c5
Compare
b6d21c5
to
bb0ada3
Compare
This allows to skip passkey tests when the functionality isn't provided. Signed-off-by: Iker Pedrosa <[email protected]>
This allows to skip passkey tests when the functionality isn't provided. Signed-off-by: Iker Pedrosa <[email protected]>
bb0ada3
to
e5ad5d5
Compare
Description
This allows to skip passkey tests when the functionality isn't provided.
Requires: next-actions/pytest-mh#15 and #42 to work.
How to test
I have created a new branch, ikerexxe/testmarker2, that contains all the changes necessary from this project to test.
In the sssd project, where your test lies, edit the
requirements.txt
file to point to the revision that we'd like to test:Create a new test case that depends on the passkey functionality:
Run the test and check that it works as expected.