-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssh: adding expect reponse to connection closed #38
Conversation
Hi Dan, can you remove the other 2 commits from this PR? Otherwise Ack from me. |
@justin-stephenson , mark it approved and I'll rebase it as the others get merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I won't approve until the other two PRs are merged. I'll review them again to check what's missing to merge them.
1d533f8
to
0605095
Compare
@justin-stephenson, Now that I'm no longer testing the test code, I remove all irrelevant PRs. This is good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the patch!
No description provided.