-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: adding dnf support #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Hi, why do you need dnf? All packages should be installed by sssd-ci-containers project. In an unlikely case that you need dnf for something very specific, you must make sure to revert changes done by dnf during teardown. |
For the authselect tests, there is a test to ensure that the minimal profile doesn't require sssd-ad, sssd-ldap and other packages. How do you propose that we write that test? It is more of a functional system/build/maintainer test. |
What's exactly the package that you need to install to test it? |
Me and Dan talked, one use case (removing the sssd packages) can be implemented in other way. Second use case is about removing authselect and verifying that authselect configuration was converted to non-authselect configuration which really requires the authselect package to be removed. For this Dan needs dnf support, but the changes must be automatically reverted. Using dnf history undo will help here. Perhaps we can get current history ID when we first use dnf and then revert to this id on teardown. |
The code for this test case is tough to read. We will certainly improve it when porting the test suite over. As far as I can tell, sssd-client, sssd-common, sssd-nfs-idmap
|
9558a60
to
1f820c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the patch!
f5b6bf0
to
36d0789
Compare
Signed-off-by: Dan Lavu <[email protected]>
Added "-y" to the module so we don't have to pass it through each time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looked good; now it looks better. Thanks.
No description provided.