Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sssdutils: adding with-mkhomedir common configuration #125

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

danlavu
Copy link

@danlavu danlavu commented Sep 23, 2024

No description provided.

@danlavu
Copy link
Author

danlavu commented Sep 24, 2024

Test >> SSSD/sssd#7617

Copy link
Member

@pbrezina pbrezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dan, could you please split the doc changes to another commit?

It is a good practice to keep commits small so it is easy to revert the patch if needed. If you revert the patch now, you also revert the doc changes.

Otherwise ack.

@danlavu danlavu force-pushed the config-oddjob branch 2 times, most recently from a8b8a61 to 0574303 Compare September 24, 2024 19:11
@danlavu
Copy link
Author

danlavu commented Sep 24, 2024

@pbrezina Done, added one thing to the function, parameterized the homedir path and it defaults to '/home'

@pbrezina pbrezina merged commit 5b5094b into SSSD:master Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants