Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Authentication Support #123

Open
wants to merge 63 commits into
base: master
Choose a base branch
from

Conversation

alexlobanov
Copy link

@alexlobanov alexlobanov commented Mar 21, 2019

Hi,

Thanks for this awesome package.

This PR contain new feature - Basic authentication Support for webpages.
You will able to set UserName and Password from XAML Bindings or C#.

Change Log:

  • Implemented Basic Auth support on iOS and Android platforms
  • Added comments/documentation on the code side
  • Added TEST case on Sample Project
  • Updated documentation

XAML usage example:

<webview:FormsWebView x:Name="internetContent" 
                  Username="BasicUsername"
                  Password="BasicPassword"
                  ContentType="Internet"
                  Source="https://example.com/" />

C# usage example:

FormsWebView WebView = new FormsWebView() {
    ContentType = WebContentType.Internet,
    Source = "http://www.somewebsite.com",
    Username = "basicAuthUser",
    Password = "basicAuthPassword"
}

Kasper Rynning-Tønnesen and others added 30 commits June 28, 2018 13:19
- Works and tested with Android
- Works and tested with iOS
- Works and tested with macOS
- Needs testing with UWP
TODO - Missing function for removing/setting specific cookie on UWP
- Sending Cookie object to cookie-setter function, to avoid having to set too much values programmatically, forced
- Changed some functionnames to fit better with C# naming-convention
- Changed some input/output parameter-names to give a better picture of whats being sent without spelling everything out in black and white
- I have absolutely no idea if these work
…tton for cookies to the bottom of the list
…Standard 2.0. Upgraded packages to latest version. Migrated SampleApp from PCL to NET Standard 2.0. Migrated all projects from packages.config to PackageReference (except SampleApp.UWP and Xam.Plugin.WebView.UWP)
…he WKWebView probably due to WKWebView WKNavigationDelegate DecidePolicy runs in another process that does not get access to the WKHttpCookieStore's cookies as the may be added through a different process. This is attempted to be solved by ensuring that the same instance of WKProcessPool is set on WKWebViewConfiguration.
Øyvind Liland and others added 15 commits February 28, 2019 14:51
…gin.Webview into cookies

* 'cookies' of https://github.com/AbarisConsulting/Xam.Plugin.Webview:
  Working with response header and content type
  Package upgrade
  Implemented FileChooser in FormsWebViewChromeClient for Android
  Version bump
  Minor changes...

# Conflicts:
#	Xam.Plugin.WebView.Abstractions/Xam.Plugin.WebView.Abstractions.csproj
#	Xam.Plugin.WebView.Droid/FormsWebViewRenderer.cs
#	Xam.Plugin.WebView.iOS/FormsWebViewRenderer.cs
#	Xam.Plugin.WebView.iOS/Xam.Plugin.WebView.iOS.csproj
Fix cookies on ios
@mdima
Copy link

mdima commented Mar 28, 2019

:D is seems a duplicate of this: #122

@alexlobanov
Copy link
Author

@mdima yeah, started work on it before taking a look on PR :)

@mdima
Copy link

mdima commented Mar 29, 2019

Eh... you know, I just returned from Minsk, I stayed there 3 weeks this month...

NGumby and others added 11 commits May 9, 2019 15:36
Handle Disposed control on Android
Handle about:blank on ios
Update nuget packages
Fixes for ios
# Conflicts:
#	.DS_Store
#	SampleApp/SampleApp.Droid/SampleApp.Droid.csproj
#	SampleApp/SampleApp/SampleApp.csproj
#	Xam.Plugin.WebView.Abstractions/IFormsWebView.cs
#	Xam.Plugin.WebView.Droid/FormsWebViewClient.cs
@svenfulen
Copy link

Can we PLEASE merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants