-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Authentication Support #123
Open
alexlobanov
wants to merge
63
commits into
SKLn-Rad:master
Choose a base branch
from
alexlobanov:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Works and tested with Android - Works and tested with iOS - Works and tested with macOS - Needs testing with UWP TODO - Missing function for removing/setting specific cookie on UWP
- Sending Cookie object to cookie-setter function, to avoid having to set too much values programmatically, forced - Changed some functionnames to fit better with C# naming-convention - Changed some input/output parameter-names to give a better picture of whats being sent without spelling everything out in black and white
- I have absolutely no idea if these work
…all cookies for a given site
…tton for cookies to the bottom of the list
…Standard 2.0. Upgraded packages to latest version. Migrated SampleApp from PCL to NET Standard 2.0. Migrated all projects from packages.config to PackageReference (except SampleApp.UWP and Xam.Plugin.WebView.UWP)
…he WKWebView probably due to WKWebView WKNavigationDelegate DecidePolicy runs in another process that does not get access to the WKHttpCookieStore's cookies as the may be added through a different process. This is attempted to be solved by ensuring that the same instance of WKProcessPool is set on WKWebViewConfiguration.
…a url to request the cookie for.
…gin.Webview into cookies * 'cookies' of https://github.com/AbarisConsulting/Xam.Plugin.Webview: Working with response header and content type Package upgrade Implemented FileChooser in FormsWebViewChromeClient for Android Version bump Minor changes... # Conflicts: # Xam.Plugin.WebView.Abstractions/Xam.Plugin.WebView.Abstractions.csproj # Xam.Plugin.WebView.Droid/FormsWebViewRenderer.cs # Xam.Plugin.WebView.iOS/FormsWebViewRenderer.cs # Xam.Plugin.WebView.iOS/Xam.Plugin.WebView.iOS.csproj
Fix cookies on ios
…ri like behaviour in the App
:D is seems a duplicate of this: #122 |
@mdima yeah, started work on it before taking a look on PR :) |
Eh... you know, I just returned from Minsk, I stayed there 3 weeks this month... |
Handle Disposed control on Android Handle about:blank on ios
Fixes for ios
# Conflicts: # .DS_Store # SampleApp/SampleApp.Droid/SampleApp.Droid.csproj # SampleApp/SampleApp/SampleApp.csproj # Xam.Plugin.WebView.Abstractions/IFormsWebView.cs # Xam.Plugin.WebView.Droid/FormsWebViewClient.cs
Can we PLEASE merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for this awesome package.
This PR contain new feature - Basic authentication Support for webpages.
You will able to set UserName and Password from XAML Bindings or C#.
Change Log:
XAML usage example:
C# usage example: