-
Notifications
You must be signed in to change notification settings - Fork 2
[BE] SISC1 [FIX] Change @Controller to @RestController for Swagger #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthrough두 개의 Spring MVC 컨트롤러 클래스에서 @controller 어노테이션을 @RestController로 변경했습니다. 이 변경은 뷰 렌더링 기반 접근에서 RESTful JSON 응답 기반 접근으로 전환됩니다. 메서드 시그니처와 라우팅 로직은 유지됩니다. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceController.java (1)
29-30: 주석의 오타를 수정하세요.주석에 몇 가지 오타가 있습니다:
- "이요한" → "이용한"
- "춣석" → "출석"
- "위도우" → "윈도우"
다음 diff를 적용하여 오타를 수정하세요:
/** * 학생 출석 체크인 - * - 출석 코드와 GPS 위치를 이요한 춣석 처리 - * - 위치 범위, 시간 위도우 검증 포함 + * - 출석 코드와 GPS 위치를 이용한 출석 처리 + * - 위치 범위, 시간 윈도우 검증 포함 * - 중복 출석 방지 */
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceController.java(1 hunks)backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceSessionController.java(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceController.java (1)
backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceSessionController.java (1)
RestController(18-211)
backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceSessionController.java (1)
backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceController.java (1)
RestController(19-100)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Backend Gate
🔇 Additional comments (2)
backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceController.java (1)
19-19: @RestController 변경이 적절합니다!
@Controller에서@RestController로의 변경이 올바릅니다. 모든 메서드가ResponseEntity를 반환하므로 RESTful API 패턴과 일치하며, Swagger 문서화도 개선됩니다.backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceSessionController.java (1)
18-18: @RestController 변경이 완벽합니다!
@RestController로의 변경이 적절하며,AttendanceController와 일관성을 유지합니다. 모든 엔드포인트가ResponseEntity를 반환하므로 REST API 설계와 완벽하게 일치하며, PR 목표대로 Swagger 문서화가 개선됩니다.
discipline24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다
Summary by CodeRabbit
릴리스 노트