[FE] SISC1-182 [FIX] 로그인, 회원가입 페이지 기능&디자인 수정 #60
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,11 +49,18 @@ const LoginForm = () => { | |
| <> | ||
| <div className={styles.formContainer}> | ||
| <form className={styles.loginForm} onSubmit={handleLogin}> | ||
| <div className={styles.header}> | ||
| <div className={styles.logoBox}> | ||
| <img | ||
| src={sejong_logo} | ||
| alt="sejong_logo" | ||
| className={styles.logo} | ||
| /> | ||
| </div> | ||
|
|
||
| <h1>Sejong Investment Scholars Club</h1> | ||
| </div> | ||
|
|
||
| <div className={styles.inputGroup}> | ||
| <label htmlFor="email">Email</label> | ||
| <input | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,44 @@ | ||
| import styles from './SocialLoginButtons.module.css'; | ||
|
|
||
| import googleIcon from './../../assets/google.png'; | ||
| import kakaoIcon from './../../assets/kakao.png'; | ||
| import githubIcon from './../../assets/github.png'; | ||
|
|
||
| const SocialLoginButtons = ({ onGoogle, onGithub, onKakao }) => { | ||
| return ( | ||
| <div className={styles.socialContainer} aria-label="소셜 로그인"> | ||
| <div className={styles.buttonGroup}> | ||
| <button | ||
| type="button" | ||
| className={`${styles.btn} ${styles.google}`} | ||
| onClick={onGoogle} | ||
| alt="구글로 로그인" | ||
|
There was a problem hiding this comment. button 요소에서 잘못된 alt 속성을 제거하세요.
다음 diff를 적용하여 수정하세요: <button
type="button"
className={`${styles.btn} ${styles.google}`}
onClick={onGoogle}
- alt="구글로 로그인"
+ aria-label="구글로 로그인"
>
<button
type="button"
className={`${styles.btn} ${styles.github}`}
onClick={onGithub}
- alt="깃허브로 로그인"
+ aria-label="깃허브로 로그인"
>
<button
type="button"
className={`${styles.btn} ${styles.kakao}`}
onClick={onKakao}
- alt="카카오로 로그인"
+ aria-label="카카오로 로그인"
>Also applies to: 25-25, 37-37 🤖 Prompt for AI AgentsThere was a problem hiding this comment. @NaturalSoda4552, 감사합니다! 수정해 주셔서 감사합니다. |
||
| > | ||
| <img src={googleIcon} /> | ||
|
There was a problem hiding this comment. 이미지에 대체 텍스트를 추가하세요. 모든 다음 diff를 적용하세요: - <img src={googleIcon} />
+ <img src={googleIcon} alt="Google 아이콘" />
- <img src={githubIcon} />
+ <img src={githubIcon} alt="GitHub 아이콘" />
- <img src={kakaoIcon} />
+ <img src={kakaoIcon} alt="Kakao 아이콘" />Also applies to: 27-27, 39-39 🤖 Prompt for AI Agents |
||
| <div className={styles.btnText}>Google로 로그인하기</div> | ||
| </button> | ||
|
|
||
| <button | ||
| type="button" | ||
| className={`${styles.btn} ${styles.github}`} | ||
| onClick={onGithub} | ||
| alt="깃허브로 로그인" | ||
| > | ||
| <img src={githubIcon} /> | ||
| <div className={`${styles.btnText} ${styles.githubBtnText}`}> | ||
| Github로 로그인하기 | ||
| </div> | ||
| </button> | ||
|
|
||
| <button | ||
| type="button" | ||
| className={`${styles.btn} ${styles.kakao}`} | ||
| onClick={onKakao} | ||
| alt="카카오로 로그인" | ||
| > | ||
| <img src={kakaoIcon} /> | ||
| <div className={styles.btnText}>kakao로 로그인하기</div> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| ); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,5 +1,5 @@ | ||||||||||||||
| .socialContainer { | ||||||||||||||
| margin-top: 30px; | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| .divider { | ||||||||||||||
|
|
@@ -12,58 +12,57 @@ | |||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| .buttonGroup { | ||||||||||||||
| display: flex; | ||||||||||||||
| flex-direction: column; | ||||||||||||||
| gap: 12px; | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| .btn { | ||||||||||||||
| width: 330px; | ||||||||||||||
| height: 44px; | ||||||||||||||
| flex-shrink: 0; | ||||||||||||||
| border-radius: 8px; | ||||||||||||||
| border: none; | ||||||||||||||
|
|
||||||||||||||
| display: flex; | ||||||||||||||
| align-items: center; | ||||||||||||||
| justify-content: center; | ||||||||||||||
| gap: 4px; | ||||||||||||||
| } | ||||||||||||||
| .btn:hover { | ||||||||||||||
| filter: brightness(0.95); | ||||||||||||||
| transition: 0.1s; | ||||||||||||||
| } | ||||||||||||||
| .btn img { | ||||||||||||||
| width: 24px; | ||||||||||||||
| height: 24px; | ||||||||||||||
| flex-shrink: 0; | ||||||||||||||
| aspect-ratio: 1/1; | ||||||||||||||
| } | ||||||||||||||
| .btn .btnText { | ||||||||||||||
| /* color: #000; */ | ||||||||||||||
| font-family: Pretendard; | ||||||||||||||
|
|
||||||||||||||
| font-size: 14px; | ||||||||||||||
| font-style: normal; | ||||||||||||||
| font-weight: 400; | ||||||||||||||
| line-height: normal; | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| .google { | ||||||||||||||
| border: 1px solid #acacac; | ||||||||||||||
| background: #fff; | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| .github { | ||||||||||||||
| background: #1a1e24; | ||||||||||||||
| color: #fff; | ||||||||||||||
| } | ||||||||||||||
| .btnText .githubBtnText { | ||||||||||||||
| color: #fff; | ||||||||||||||
| } | ||||||||||||||
|
Comment on lines
+60
to
62
There was a problem hiding this comment. CSS 선택자를 수정하세요. 현재 선택자 다음 diff를 적용하세요: -.btnText .githubBtnText {
+.btnText.githubBtnText {
color: #fff;
}📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
|
|
||||||||||||||
| .kakao { | ||||||||||||||
| background: #fae000; | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| .label { | ||||||||||||||
|
|
||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
빈 Home 컴포넌트로의 라우팅 변경을 확인하세요.
루트 경로가 Login에서 Home으로 변경되었습니다. 제공된 코드 스니펫에 따르면 Home 컴포넌트는 현재 빈 div만 반환합니다. 다음 사항을 확인해주세요:
다음 스크립트를 실행하여 Home 컴포넌트의 현재 구현을 확인하세요:
🏁 Script executed:
Length of output: 67
루트 경로를 빈 Home 컴포넌트로 변경하며 인증 제어 로직이 없습니다
<div></div>만 반환합니다.변경 의도를 확인하고, 루트 접근에 대한 인증 리디렉션을 구현하세요.
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추후 수정하겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NaturalSoda4552, 알겠습니다! 나중에 수정하시는 것으로 확인했습니다.
이 작업을 추적하기 위해 별도의 이슈를 생성하시겠습니까? 원하신다면 인증 제어 로직 추가에 대한 후속 이슈를 만들어 드릴 수 있습니다.