Converter Restructuring #1782
Draft
Converter Restructuring #1782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
improvement
heinezen
force-pushed
the
feature/converter_refactor
branch
2 times, most recently
from
303c613 to
b5149f6
Compare
heinezen
force-pushed
the
feature/converter_refactor
branch
2 times, most recently
from
bf4d445 to
f217db5
Compare
heinezen
force-pushed
the
feature/converter_refactor
branch
from
f217db5 to
8c12272
Compare
heinezen
force-pushed
the
feature/converter_refactor
branch
from
8c12272 to
9096c3c
Compare
heinezen
force-pushed
the
feature/converter_refactor
branch
from
9096c3c to
62f1d4e
Compare
Huskarl unit has two entries for armor class 15 (probably an error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the converter a bit more maintainable.
Depends on #1688