Merge pull request #1587 from askastitva/add-atan2

Add `atan2` to `FixedPoint`
SFTtech · Nov 11, 2023 · 23e27f0 · 23e27f0
2 parents bd06a25 + d63d33e
commit 23e27f0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/copying.md b/copying.md
@@ -150,6 +150,7 @@ _the openage authors_ are:
 | Munawar Hafiz               | munahaf                     | munawar dawt hafiz à gmail dawt com               |
 | Md Ashhar                   | ashhar                      | mdashhar01 à gmail dawt com                       |
 | Fábio Barkoski              | fabiobarkoski               | fabiobarkoskii à gmail dawt com                   |
+| Astitva Kamble              | askastitva                  | astitvakamble5 à gmail dawt com                   |
 
 If you're a first-time committer, add yourself to the above list. This is not
 just for legal reasons, but also to keep an overview of all those nicknames.

diff --git a/libopenage/util/fixed_point.h b/libopenage/util/fixed_point.h
@@ -370,6 +370,10 @@ class FixedPoint {
 	constexpr double sqrt() {
 		return std::sqrt(this->to_double());
 	}
+
+	constexpr double atan2(const FixedPoint &n) {
+		return std::atan2(this->to_double(), n.to_double());
+	}
 };
 
 
@@ -481,6 +485,11 @@ constexpr double sqrt(openage::util::FixedPoint<I, F> n) {
 	return n.sqrt();
 }
 
+template <typename I, unsigned F>
+constexpr double atan2(openage::util::FixedPoint<I, F> x, openage::util::FixedPoint<I, F> y) {
+	return x.atan2(y);
+}
+
 template <typename I, unsigned F>
 constexpr openage::util::FixedPoint<I, F> min(openage::util::FixedPoint<I, F> x, openage::util::FixedPoint<I, F> y) {
 	return openage::util::FixedPoint<I, F>::from_raw_value(

diff --git a/libopenage/util/fixed_point_test.cpp b/libopenage/util/fixed_point_test.cpp
@@ -1,4 +1,4 @@
-// Copyright 2016-2018 the openage authors. See copying.md for legal info.
+// Copyright 2016-2023 the openage authors. See copying.md for legal info.
 
 #include "fixed_point.h"
 
@@ -58,6 +58,7 @@ void fixed_point() {
 	TESTEQUALS_FLOAT((e * 10).to_double(), 108.3 * 10, 1e-7);
 	TESTEQUALS_FLOAT((e / 10).to_double(), 108.3 / 10, 1e-7);
 	TESTEQUALS_FLOAT(std::sqrt(e), sqrt(108.3), 1e-7);
+	TESTEQUALS_FLOAT(std::atan2(e, f), atan2(108.3, -12.4), 1e-7);
 	TESTEQUALS_FLOAT(std::abs(-e).to_double(), 108.3, 1e-7);
 	TESTEQUALS_FLOAT(std::hypot(e, f), hypot(108.3, -12.4), 1e-7);
 	TESTEQUALS_FLOAT(std::min(e, f), -12.4, 1e-7);