Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting up Mock annotation to be used #259

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

AtillaColak
Copy link
Contributor

@AtillaColak AtillaColak commented Jul 31, 2023

I updated the tests accordingly and they passed. They were some irrelevant failures on my local about weblab credentials not logged in, so I disregarded it since it's not related to this error. Please let me know if more changes have to be done to keep consistency. This MR closes #166

Copy link
Contributor

@mauricioaniche mauricioaniche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Super neat and clean code. Congrats!

I wouldn't expect tests to fail in local. Are they marked as CI tests? They shouldn't run locally. I'll put the pipeline to run here, let's see if everything passes!

@martinmladenov martinmladenov merged commit f3bdbe7 into SERG-Delft:main Jul 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make @Mock annotation available
3 participants