Bugfix (Core, Input, Confirm, Expand, Rawlist, Password): Fix cursor …

…moves being ignored (Fix #1262)

packages/core/src/index.mts

@@ -243,6 +243,10 @@ export function createPrompt<Value, Config extends AsyncPromptConfig>(
 
     let cancel: () => void = () => {};
     const answer = new CancelablePromise<Value>((resolve, reject) => {
+      const checkCursorPos = () => {
+        screen.checkCursorPos();
+      };
+
       const onExit = () => {
         try {
           let len = hooksCleanup.length;
@@ -260,8 +264,9 @@ export function createPrompt<Value, Config extends AsyncPromptConfig>(
         }
         screen.done();
 
-        resetHookState();
         process.removeListener('SIGINT', onForceExit);
+        sessionRl?.input.removeListener('keypress', checkCursorPos);
+        resetHookState();
       };
 
       cancel = () => {
@@ -313,7 +318,15 @@ export function createPrompt<Value, Config extends AsyncPromptConfig>(
       };
 
       // TODO: we should display a loader while we get the default options.
-      getPromptConfig(config).then(workLoop, reject);
+      getPromptConfig(config).then((resolvedConfig) => {
+        workLoop(resolvedConfig);
+
+        // Re-renders only happen when the state change; but the readline cursor could change position
+        // and that also requires a re-render (and a manual one because we mute the streams).
+        // We set the listener after the initial workLoop to avoid a double render if render triggered
+        // by a state change sets the cursor to the right position.
+        sessionRl?.input.on('keypress', checkCursorPos);
+      }, reject);
     });
 
     answer.catch(() => {

packages/core/src/lib/screen-manager.mts

@@ -1,3 +1,4 @@
+import type { CursorPos } from 'node:readline';
 import cliWidth from 'cli-width';
 import stripAnsi from 'strip-ansi';
 import ansiEscapes from 'ansi-escapes';
@@ -11,9 +12,11 @@ export default class ScreenManager {
   // These variables are keeping information to allow correct prompt re-rendering
   private height: number = 0;
   private extraLinesUnderPrompt: number = 0;
+  private cursorPos: CursorPos;
 
   constructor(private readonly rl: InquirerReadline) {
     this.rl = rl;
+    this.cursorPos = rl.getCursorPos();
   }
 
   render(content: string, bottomContent: string = '') {
@@ -38,9 +41,9 @@ export default class ScreenManager {
     this.rl.setPrompt(prompt);
 
     // SetPrompt will change cursor position, now we can get correct value
-    const cursorPos = this.rl.getCursorPos();
-    const width = cliWidth({ defaultWidth: 80, output: this.rl.output });
+    this.cursorPos = this.rl.getCursorPos();
 
+    const width = cliWidth({ defaultWidth: 80, output: this.rl.output });
     content = breakLines(content, width);
     bottomContent = breakLines(bottomContent, width);
 
@@ -59,15 +62,16 @@ export default class ScreenManager {
 
     // We need to consider parts of the prompt under the cursor as part of the bottom
     // content in order to correctly cleanup and re-render.
-    const promptLineUpDiff = Math.floor(rawPromptLine.length / width) - cursorPos.rows;
+    const promptLineUpDiff =
+      Math.floor(rawPromptLine.length / width) - this.cursorPos.rows;
     const bottomContentHeight =
       promptLineUpDiff + (bottomContent ? height(bottomContent) : 0);
 
     // Return cursor to the input position (on top of the bottomContent)
     if (bottomContentHeight > 0) output += ansiEscapes.cursorUp(bottomContentHeight);
 
     // Return cursor to the initial left offset.
-    output += ansiEscapes.cursorTo(cursorPos.cols);
+    output += ansiEscapes.cursorTo(this.cursorPos.cols);
 
     /**
      * Set up state for next re-rendering
@@ -79,6 +83,16 @@ export default class ScreenManager {
     this.rl.output.mute();
   }
 
+  checkCursorPos() {
+    const cursorPos = this.rl.getCursorPos();
+    if (cursorPos.cols !== this.cursorPos.cols) {
+      this.rl.output.unmute();
+      this.rl.output.write(ansiEscapes.cursorTo(cursorPos.cols));
+      this.rl.output.mute();
+      this.cursorPos = cursorPos;
+    }
+  }
+
   clean() {
     this.rl.output.unmute();
     this.rl.output.write(