docs(ui5-shellbar): new sample added #10590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't use fix for samples. Instead use docs. |
PetyaMarkovaBogdanova
changed the title
|
Blocked until #10595 is merged. |
added 2 commits
January 27, 2025 09:19
ilhan007
reviewed
Jan 31, 2025
| @@ -1,5 +1,6 @@ | |||
| import Basic from "../../../_samples/fiori/ShellBar/Basic/Basic.md"; | |||
| import Advanced from "../../../_samples/fiori/ShellBar/Advanced/Advanced.md"; | |||
| import WithAdditionalContext from "../../../_samples/fiori/ShellBar/WithAdditionalContext/WithAdditionalContext.md"; | |||
There was a problem hiding this comment.
WithAdditionalContext sounds too technical,
Currently we have the BasicSample and Profile Area, so maybe add Content Area
or rename Profile Area to With Profile Area and add With Content Area
or something among these lines
ilhan007
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New sample added, presenting Shellbar new functionality and design.