chore: replace event marking with focus-within #10097
Open
+34
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
approved these changes
Oct 30, 2024
TeodorTaushanov
approved these changes
Oct 30, 2024
dobrinyonkov
approved these changes
Oct 31, 2024
hinzzx
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, event marking was used to identify the origin of an event from a specific component, preventing unintended interactions with other components. This approach prevented redundant event processing, particularly in cases of component composition.
Now, if a component receives focus, it will manage most events. The :has(:focus-within) selector checks if the current element (typically the root element) has a focusable child. If a child is focused, we assume it will handle user interactions.