fix(ui5-dynamic-page): improve scrolling smoothness #10093
+60
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Description When scrolling, the header content would snap into place, causing an unintended shift in the page content scroll position. This resulted in the main content scrolling further down than expected, disrupting the user’s view. Root Cause Snapping the header set the height of the headerArea content to 0, causing a layout shift. This shift created additional space, which moved the main content of the dynamic page upwards unexpectedly. Fix Details - Modified `snapTitleByScroll` to handle snapping conditions more precisely, using `requestAnimationFrame` to wait for rendering to complete before adjusting scroll positions. - Adjusted logic to maintain a stable scroll position when the header snaps or unsnaps, preventing unnecessary layout shifts. Outcome The header now snaps smoothly, maintaining the main content’s scroll position and providing a seamless user experience. Fixes: #10011
kgogov
force-pushed
the
dynamic-page-fix
branch
from
52d1f7b
to
717fab7
Compare
Bug Description When scrolling, the header content would snap into place, causing an unintended shift in the page content scroll position. This resulted in the main content scrolling further down than expected, disrupting the user’s view. Root Cause Snapping the header set the height of the headerArea content to 0, causing a layout shift. This shift created additional space, which moved the main content of the dynamic page upwards unexpectedly. Fix Details - Modified `snapTitleByScroll` to handle snapping conditions more precisely, using `requestAnimationFrame` to wait for rendering to complete before adjusting scroll positions. - Adjusted logic to maintain a stable scroll position when the header snaps or unsnaps, preventing unnecessary layout shifts. Outcome The header now snaps smoothly, maintaining the main content’s scroll position and providing a seamless user experience. Fixes: #10011
kgogov
force-pushed
the
dynamic-page-fix
branch
from
717fab7
to
150cb6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
When scrolling, the header content would snap into place, causing an unintended shift in the page content scroll position. This resulted in the main content scrolling further down than expected, disrupting the user’s view.
Root Cause
Snapping the header set the height of the
headerAreacontent to 0, causing a layout shift. This shift created additional space, which moved the main content of the dynamic page upwards unexpectedly.Fix Details
snapTitleByScrollto handle snapping conditions more precisely, usingrequestAnimationFrameto wait for rendering to complete before adjusting scroll positions.Outcome
The header now snaps smoothly, maintaining the main content’s scroll position and providing a seamless user experience.
Fixes: #10011