Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-text): match enum and file names #10084

Merged
merged 2 commits into from
Oct 25, 2024
Merged

refactor(ui5-text): match enum and file names #10084

merged 2 commits into from
Oct 25, 2024

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Oct 25, 2024

Match enum and file name - either use EmptyIndictaroMode for both, or TextEmptyIndictaroMode for both. As currently only the Text is known to have such mode - the change uses TextEmptyIndictaroMode for the enum and the file name.

@ilhan007 ilhan007 changed the title refactor(ui5-text): declare enum prop as option, match enum and file … refactor(ui5-text): match enum and file names Oct 25, 2024
@ilhan007 ilhan007 merged commit 036baa9 into main Oct 25, 2024
10 checks passed
@ilhan007 ilhan007 deleted the text-refactoring branch October 25, 2024 14:57
kgogov pushed a commit that referenced this pull request Oct 30, 2024
Match enum and file name - either use EmptyIndictaroMode for both, or TextEmptyIndictaroMode for both. As currently only the Text is known to have such mode - the change uses TextEmptyIndictaroMode for the enum and the file n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants