[FIX] Explicitly bind to IPv4 loopback #763
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
fix/bind-to-v4-loopback
branch
from
fc36a77 to
8a688bd
Compare
In some environments, 'localhost' might resolve to the IPv6 loopback address '::1' which is often unexpected. This can especially lead to problems where other tools might resolve 'localhost' differently in the same environment. This change explicitly binds to the IPv4 loopback address '127.0.0.1' instead of resolving the address from 'localhost'. In case remote connections are allowed, no host is specified so that Node.js binds to either the unspecified IPv4 or -IPv6 address (which usually also accepts IPv4 connections) [1] [1] https://nodejs.org/docs/latest-v25.x/api/net.html#serverlistenport-host-backlog-callback
RandomByte
force-pushed
the
fix/bind-to-v4-loopback
branch
from
8a688bd to
31b5018
Compare
Member
|
Unfortunately at least for me, while testing with Docker engine v28.3.0, this didn't fix the issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments, 'localhost' might resolve to the IPv6 loopback
address '::1' which is often unexpected. This can especially lead to
problems where other tools might resolve 'localhost' differently in the
same environment.
This change explicitly binds to the IPv4 loopback address '127.0.0.1'
instead of resolving the address from 'localhost'.
In case remote connections are allowed, no host is specified so that
Node.js binds to either the unspecified IPv4 or -IPv6 address (which
usually also accepts IPv4 connections) [1]
[1] https://nodejs.org/docs/latest-v25.x/api/net.html#serverlistenport-host-backlog-callback