Conversation
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
3 similar comments
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
private.providers.ts, centralize common configs of b2b- and b2c- into one configuration.module.ts, extract b2b- and b2c- providers to separate files (#21120)"
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
private.providers.ts, centralize common configs of b2b- and b2c- into one configuration.module.ts, extract b2b- and b2c- providers to separate files (#21120)"
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
1 similar comment
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
2 similar comments
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
pawelfras
left a comment
There was a problem hiding this comment.
Only now I realised that we have ci-scripts/update-ccv2.sh file that also refers to modules with configurations. Let's double-check (ideally with one of release masters) if the script is still in use and provide the following adjustments, if needed:
- Change APP_MODULE_PATH to projects/storefrontapp/src/app/private/private.providers.ts
- Update B2B_CONFIG_PATH to projects/storefrontapp/src/app/spartacus/spartacus-b2b-configuration.providers.ts
- Update B2C_CONFIG_PATH to projects/storefrontapp/src/app/spartacus/spartacus-b2c-configuration.providers.ts
- Adjust PWA config handling logic (now centralized in spartacus-configuration.module.ts)
This reverts commit 70bc432.
What:
We're moving the OCC backend (and Media backend) configuration in
storefrontappfromapp.module.tstospartacus-configuration.module.ts- to mimic better the fresh apps which have this config in theirspartacus-configuration.module.ts.And we extracting repeated config from
spartacus-b2b-...andspartacus-b2c-configuration.module.tsto onespartacus-configuration.module.tsand moving the differing parts to renamed b2b and b2c... .providers.tsfiles.Why:
In https://jira.tools.sap/browse/CXSPA-11890 we've modernized storefrontapp to look more like a fresh app - i.e. we moved around configs between app.module, spartacus-storefront.module, spartacus-b2b-storefront.module, spartacus-b2c-storefront.module
But it turned our it broke our
ec-automate-pipelinesscripts, which caused deployment scripts to fail. So we quickly reverted those modernizations of storefrontapp in https://jira.tools.sap/browse/CXSPA-12046 (#21120) , to unblock the testing of the Feb2026 release, with the help of necessary deployment scriptsBut now, after we're done with Feb2026 release, we'd like to bring back the modernization of the storefrontapp, and then we'll adjust the
ec-automate-pipelinesscript.Conflicts resolved with recent changes in develop
While applying a revert I resolved 2 conflicts with changes that were added in the meantime on
develop:backend.mediaconfig has been added toapp.module.tsin feat: add mediaApiPrefix env var and backend.media.prefix config #21096 -> so I've moved it toprivate.providers.ts(near backend.occ` configpwa.enableconfig has been disabled in github.com/chore: disable service worker in storefrontapp #21116 -> so I also keep it disabledNotes for adjusting
ec-automate-pipelines: (generated with Opus 4.5 and human-edited)OLD Expectations of ec-automate-pipelines:
projects/storefrontapp/src/app/app.module.tsbaseUrl: environment.occBaseUrlspartacus-b2b-configuration.module.ts(NgModule with@NgModule({ providers: [...] }))providers: [array inside NgModule decoratorspartacus-b2c-configuration.module.ts(NgModule)spartacus-b2b-configuration.module.tsspartacus-b2c-configuration.module.tsNEW Expectations of ec-automate-pipelines should be:
projects/storefrontapp/src/app/private/private.providers.ts(no longer contains OCC config)app.module.tsbaseUrl: environment.occBaseUrlspartacus-b2b-configuration.providers.ts(deleted)spartacus-b2b-configuration.module.tsmakeEnvironmentProviders([...])instead of NgModulespartacus-b2c-configuration.providers.ts(standalone providers function)(deleted)spartacus-b2c-configuration.module.tsspartacus-configuration.module.ts(single location)B2B and B2C modules separately(removed)fixes https://jira.tools.sap/browse/CXSPA-12047