Skip to content

fix: Fix info center layout issue #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix info center layout issue #3453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/control-property-editor/src/panels/RightPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,21 @@ export function RightPanel(): ReactElement {
const scenario = useSelector<RootState, Scenario>((state) => state.scenario);
const infoCenterMessagesCount = useSelector<RootState, number>((state) => state.infoCenterMessages.length);

const rowSize = 100;
const actionsRowHeight = 100;
const header = 50;
const initialSizeQuickActions = actionsCount * rowSize + header;
const initialSizeInfoCenter = infoCenterMessagesCount * rowSize + header;
/**
* The info center can accommodate at most {@link infoCenterMaxRowsCount} rows
* with height of {@link infoCenterMaxRowHeight} each, initially.
*/
const infoCenterMaxRowsCount = 3;
// Each info center row item contains a title, description and actions(less/more, view details).
// The descriotption can contain max 4 lines with ellipsis and if the text content is more we have a `more`
// button to expand it. So the 130px seems to be the max height for each info center item when not expanded.
const infoCenterMaxRowHeight = 130;

const initialSizeQuickActions = actionsCount * actionsRowHeight + header;
const initialSizeInfoCenter =
Math.min(infoCenterMessagesCount, infoCenterMaxRowsCount) * infoCenterMaxRowHeight + header;

return (
<UISections
Expand Down
Loading