Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CxONE: search project name by exact match #5187

Merged
merged 200 commits into from
Nov 27, 2024
Merged

CxONE: search project name by exact match #5187

merged 200 commits into from
Nov 27, 2024

Conversation

thtri
Copy link
Member

@thtri thtri commented Nov 27, 2024

Description

This PR contains 2 changes:

  • to search for project name via exact match
  • to remove the absolute file location in SARIF format

Checklist

  • Tests
  • Documentation
  • Inner source library needs updating

michaelkubiaczyk and others added 30 commits November 4, 2022 12:25
@michaelkubiaczyk
Initial in progress
16be592
@michaelkubiaczyk
compiling but not yet functional
de651f1
@michaelkubiaczyk
Missed file
a436443
@michaelkubiaczyk
updated checkmarxone step
cfea40b
@michaelkubiaczyk
Working up to fetching a project then breaks
065a1e9
@michaelkubiaczyk
Missed file
b4273f3
@michaelkubiaczyk
Breaks when retrieving projects+proxy set
e820ee0
@michaelkubiaczyk
Create project & run scan working, now polling
6f92b53
@michaelkubiaczyk
Fixed polling
c78bc9f
@michaelkubiaczyk
added back the zipfile remove command
5177571
@michaelkubiaczyk
Fixed polling again
e9a211d
@michaelkubiaczyk
Generates and downloads PDF report
191086b
@michaelkubiaczyk
Updated and working, prep for refactor
457b33c
@michaelkubiaczyk
Added compliance steps
b04fffb
@michaelkubiaczyk
Cleanup, reporting, added groovy connector
58955ed
@michaelkubiaczyk
fixed groovy file
caad45f
@michaelkubiaczyk
checkmarxone to checkmarxOne
b099628
@michaelkubiaczyk
checkmarxone to checkmarxOne
b65e1d6
@michaelkubiaczyk
split credentials (id+secret, apikey), renamed pullrequestname to bra…
dec8b87 
…nch, groovy fix
@michaelkubiaczyk
Fixed filenames & yaml
fc906a7
@michaelkubiaczyk
missed the metadata_generated.go
94be026
@michaelkubiaczyk
added json to sarif conversion
0e5e0d4
@thtri
Merge branch 'SAP:master' into cxone-dev-michael
809b3da
@thtri
Merge branch 'SAP:master' into cxone-dev-michael
912fd6f
@thtri
fix:type in new checkmarxone package
8897428
@thtri
fix:type in new checkmarxone package
aa61c8f
@michaelkubiaczyk
removed test logs, added temp error log for creds
183a110
@michaelkubiaczyk
extra debugging to fix crash
7070344
@michaelkubiaczyk
improved auth logging, fixed query parse issue
d360dd4
@michaelkubiaczyk
fixed bug with group fetch when using oauth user
b20c5cb
michaelkubiaczyk and others added 20 commits October 8, 2024 15:15
@michaelkubiaczyk
Merge branch 'SAP:master' into cxone-dev
b038210
@michaelkubiaczyk
Merge pull request #50 from hubadr/cxone-release
d8622e6 
Cxone release
@michaelkubiaczyk
adding RequestNewPDFReport function using v2 api
54a8f77
@michaelkubiaczyk
added version check
dedc29a
@thtri
fix(cxone): JSON report using v2 API
6a651f3
@michaelkubiaczyk
update to set reportType in v2 reportgen
9957830
@hubadr
Merge pull request #51 from hubadr/cxone-dev-michael
f8ca520 
Cxone dev michael
@thtri
Merge branch 'master' into cxone-dev
ed29064
@thtri
Merge branch 'SAP:master' into cxone-release
4e5c903
@thtri
Merge branch 'SAP:master' into cxone-dev
493c600
@thtri
Merge branch 'SAP:master' into cxone-dev-thanh
c67a4ae
@thtri
fix(checkmarxOneExecuteScan): remove absolute patch for code preview
3ecc685
@thtri
fix(checkmarxOneExecuteScan): remove SCA confusion from driver name
2812aff
@thtri
fix(checkmarxOneExecuteScan): search project name by exact match
9330d46
@thtri
Merge branch 'SAP:master' into cxone-release
c515833
@thtri
Merge branch 'SAP:master' into cxone-dev
9ddb6b8
@thtri
Merge branch 'SAP:master' into cxone-dev-thanh
fdba6a8
@thtri
fix(checkmarxOneExecuteScan): escape branch name in deeplink
fc253d1
@thtri
Merge pull request #52 from hubadr/cxone-dev-thanh
f12e15e 
Cxone dev thanh
@thtri
Merge pull request #53 from hubadr/cxone-dev
cbc75bc 
Cxone dev
@thtri thtri requested a review from a team as a code owner November 27, 2024 11:14
@thtri thtri requested a review from hubadr November 27, 2024 11:14
hubadr
hubadr approved these changes Nov 27, 2024
View reviewed changes
pkg/checkmarxone/cxjson_to_sarif.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know what tool.Driver.Name is meant for, but maybe it is safer not use whitespaces in this name? Like CheckmarxOne

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@thtri
Copy link
Member Author

thtri commented Nov 27, 2024

/it-go

@thtri thtri merged commit cd20114 into SAP:master Nov 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubadr hubadr hubadr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thtri @hubadr @michaelkubiaczyk @sumeetpatil