Skip to content

Conversation

@notque
Copy link
Contributor

@notque notque commented Jul 29, 2025

I worry about compatibility for Elektra. I need to do a better job of understanding the module in elektra and how it might need to change.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16583203519

Details

  • 166 of 180 (92.22%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.5%) to 62.155%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/api/events.go 3 5 60.0%
pkg/storage/elasticsearch.go 34 46 73.91%
Totals Coverage Status
Change from base Build 16505671048: 6.5%
Covered Lines: 721
Relevant Lines: 1160

💛 - Coveralls

viennaa
viennaa previously approved these changes Sep 3, 2025
SuperSandro2000
SuperSandro2000 previously approved these changes Sep 3, 2025
@notque notque dismissed stale reviews from SuperSandro2000 and viennaa via 7be560c October 3, 2025 15:50
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/SAP-cloud-infrastructure/hermez/pkg/api 0.00% (ø)
github.com/SAP-cloud-infrastructure/hermez/pkg/storage 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/SAP-cloud-infrastructure/hermez/pkg/api/events.go 0.00% (ø) 0 0 0
github.com/SAP-cloud-infrastructure/hermez/pkg/api/middleware.go 0.00% (ø) 0 0 0
github.com/SAP-cloud-infrastructure/hermez/pkg/api/response.go 0.00% (ø) 0 0 0
github.com/SAP-cloud-infrastructure/hermez/pkg/storage/elasticsearch.go 0.00% (ø) 0 0 0
github.com/SAP-cloud-infrastructure/hermez/pkg/storage/errors.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/SAP-cloud-infrastructure/hermez/pkg/api/response_test.go
  • github.com/SAP-cloud-infrastructure/hermez/pkg/storage/elasticsearch_errors_test.go
  • github.com/SAP-cloud-infrastructure/hermez/pkg/storage/errors_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants