Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POST binding for AuthNRequest #239

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

flupzor
Copy link
Contributor

@flupzor flupzor commented Jan 28, 2021

This adds support for the POST binding to 'login' flow.

@pitbulk
Copy link
Contributor

pitbulk commented Jan 28, 2021

Adding this opens the door to support the ability to generate LogoutRequest/LogoutResponses via HTTP-POST as well as be able to process them, so at the end, some extra complexity to the toolkit.

@flupzor flupzor force-pushed the pr-post-binding-rebased branch from 5537390 to 639d326 Compare January 29, 2021 14:29
@flupzor
Copy link
Contributor Author

flupzor commented Jan 29, 2021

I accidentally included the commit 'Add the ability to change the ProtocolBinding in the authn request.' in this PR, while it should've been part of #237 I moved it to there.

@flupzor
Copy link
Contributor Author

flupzor commented Jan 29, 2021

@pitbulk I can appreciate keeping the project simple. I'm not entirely sure how often the POST-binding is used for the AuthNRequest.

The modification I made to get_request is something that would be useful to have (but I could even work around that by doing a reverse of deflate/base64). Otherwise I could also implement this by extending the OneLogin_Saml2_Auth class.

For the Artifact binding I actually needed some changes, which I could only do by forking the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants