Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for decrypting EncryptedIDs #238

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

flupzor
Copy link
Contributor

@flupzor flupzor commented Jan 28, 2021

This PR adds support for decrypting Responses which include EncryptedIDs in the AttributeStatement/Attribute section.

@pitbulk
Copy link
Contributor

pitbulk commented Jan 28, 2021

Not a common scenario to have EncryptedIDs instead the whole assertion encrypted, but something to review and merge.
Thanks

@flupzor flupzor force-pushed the pr-encrypted-ids-rebased branch from 9a01a84 to 08bcfd0 Compare February 25, 2021 13:51
@flupzor
Copy link
Contributor Author

flupzor commented Feb 25, 2021

I removed a commit which changed the behavior of 'validate_num_assertions'. I messed up and it should've been part of #247 and as @pitbulk pointed out, ignoring the Advice element can allow XML signature wrapping attacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants