Allow users to edit documents' fulltext fields (used in search) #139
Conversation
Restioson
force-pushed
the
feat/edit-fulltext-field
branch
from
850f6f3
to
59af2a8
Compare
There was a problem hiding this comment.
Splitting hair about commit wording: The term "fixture" you use in 56a5014 will seem to refer to the Django feature with that name: https://docs.djangoproject.com/en/5.1/topics/db/fixtures/ I guess you use it here in a more general sense.
Maybe something like "Reuse test institution" will be fine or anything in similar vein.
Regarding this, I say fixture as it is a common way to refer to setup and teardown in testing frameworks. E.g., from the Happy to change it to something else if you feel there's a clearer term. I think it's worth mentioning that Django fixtures are not completely orthogonal to the unittest ones though! |
|
Don't worry too much about the term "fixtures", but maybe keep in mind in future, that in the Django world, I think most people will think of the output of the management command that dumps data, rather than a general test fixture. |
Restioson
force-pushed
the
feat/edit-fulltext-field
branch
from
7f54f2f
to
ffb22ed
Compare
|
I added a very small change to the Makefile here (useful for testing) in ffb22ed - happy to cherry-pick off to another branch as well |
Restioson
force-pushed
the
feat/edit-fulltext-field
branch
from
1c13977
to
e2ce335
Compare
…nt form This is by far the slowest part of validation, and happens even if there are other issues with the form. Because Django disables client-side validation for editing model forms (see comment), we need server-side validation to be fast, so we delay PDF text extraction until all errors are fixed.
This prevents the need for having to call `Institution.objects.create` with a _globally unique_ name in each test (previously, reusing a name would cause an error)
This allows users that have the suitable permission to edit the fulltext field of Documents. This field is used when searching, so it allows users to remove frontmatter from PDFs which are irrelevant, or paste a plaintext version for a Google Doc link, for example. The field is only shown to those with the relevant permission to avoid confusing people who may not understand what it is for. When a PDF is edited for a Document, unless the fulltext is also edited at the same time (within the same form submission), it will take priority and overwrite the old fulltext (even if edited prior).
The migration and appto migrate to can now be specified by setting the `migration_args` Makefile variable on the command line, e.g. `make migrate migration_args="general 0013"`.
Restioson
force-pushed
the
feat/edit-fulltext-field
branch
from
9f17ae8
to
2c32403
Compare
This allows users that have the suitable permission to edit the fulltext field of Documents. This field is used when searching, so it allows users to remove frontmatter from PDFs which are irrelevant, or paste a plaintext version for a Google Doc link, for example. The field is only shown to those with the relevant permission to avoid confusing people who may not understand what it is for. When a PDF is edited for a Document, unless the fulltext is also edited at the same time (within the same form submission), it will take priority and overwrite the old fulltext (even if edited prior).
This PR should be rebased on top of #138 when that PR is merged, as #138 is essentially a cherry-picking of some dev experience fixes I made while working on this PR.
Fixes #137.