chore: make StreamConfig Copyable#1108
Open
Decodetalkers wants to merge 2 commits intoRustAudio:masterfrom
Open
chore: make StreamConfig Copyable#1108Decodetalkers wants to merge 2 commits intoRustAudio:masterfrom
Decodetalkers wants to merge 2 commits intoRustAudio:masterfrom
Conversation
Decodetalkers
force-pushed
the
stream_config_copy
branch
4 times, most recently
from
7a10d1e to
a677c8a
Compare
Contributor
Author
|
maybe now instead of &StreamConfig, it should be changed to StreamConfig |
roderickvd
force-pushed
the
stream_config_copy
branch
from
a677c8a to
f7f02a7
Compare
Member
I agree, let's do that and add appropriate changelog entries. |
Decodetalkers
force-pushed
the
stream_config_copy
branch
from
72a5ea8 to
f070e10
Compare
Decodetalkers
force-pushed
the
stream_config_copy
branch
from
f070e10 to
d3158d7
Compare
Member
|
Do you also want to change the parameters from |
Contributor
Author
Yes, but I want to wait for pipewire being finished first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.